Reviewing files that changed from the base of the PR and between b7f013f and 7ada4c7.

• CHANGELOG.md (1 hunks)
• modules/transport-netty4/src/test/java/org/opensearch/http/netty4/Netty4BadRequestTests.java (1 hunks)
• modules/transport-netty4/src/test/java/org/opensearch/http/netty4/Netty4HttpServerTransportTests.java (6 hunks)
• modules/transport-netty4/src/test/java/org/opensearch/http/netty4/TestDispatcherBuilder.java (1 hunks)
• modules/transport-netty4/src/test/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransportTests.java (11 hunks)
• plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ReactorNetty4BadRequestTests.java (1 hunks)
• plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpServerTransportStreamingTests.java (3 hunks)
• plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpServerTransportTests.java (8 hunks)
• plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/TestDispatcherBuilder.java (1 hunks)
• plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ssl/SecureReactorNetty4HttpServerTransportTests.java (8 hunks)

• GitHub Check: gradle-check
• GitHub Check: precommit (21, windows-2025, true)
• GitHub Check: precommit (21, macos-15)
• GitHub Check: precommit (25, macos-15)
• GitHub Check: Analyze (java)
• GitHub Check: precommit (21, ubuntu-latest)
• GitHub Check: precommit (25, macos-15-intel)
• GitHub Check: precommit (21, ubuntu-24.04-arm)
• GitHub Check: precommit (25, ubuntu-24.04-arm)
• GitHub Check: precommit (25, windows-latest)
• GitHub Check: precommit (21, windows-latest)
• GitHub Check: detect-breaking-change
• GitHub Check: precommit (25, ubuntu-latest)
• GitHub Check: precommit (21, macos-15-intel)
• GitHub Check: assemble (25, ubuntu-24.04-arm)
• GitHub Check: assemble (25, windows-latest)
• GitHub Check: assemble (25, ubuntu-latest)
• GitHub Check: assemble (21, ubuntu-24.04-arm)
• GitHub Check: assemble (21, ubuntu-latest)
• GitHub Check: assemble (21, windows-latest)
• GitHub Check: Mend Security Check

modules/transport-netty4/src/test/java/org/opensearch/http/netty4/Netty4BadRequestTests.java (3)

73-78: Non-throwing setup is fine

setup() does not throw checked exceptions, so dropping throws Exception matches the implementation and keeps the signature clean.

---

80-83: Non-throwing shutdown is appropriate

shutdown() body cannot throw checked exceptions; removing throws Exception is correct and consistent with other tests.

---

85-96: Dispatcher builder usage preserves bad‑request behavior

Using TestDispatcherBuilder.withDefaults() with a failing dispatchRequest and custom dispatchBadRequest mirrors the old anonymous Dispatcher while centralizing the common wiring; looks good.

plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ReactorNetty4BadRequestTests.java (3)

50-55: setup signature cleanup is correct

No checked exceptions are thrown here, so removing throws Exception is safe and simplifies the test.

---

57-60: shutdown signature cleanup is correct

Dropping throws Exception matches the implementation and other tests.

---

62-73: Refactored dispatcher matches previous bad‑request handling

The TestDispatcherBuilder configuration (failing normal requests, custom dispatchBadRequest) keeps the original test intent while reducing boilerplate.

plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ssl/SecureReactorNetty4HttpServerTransportTests.java (8)

32-32: Importing TestDispatcherBuilder aligns secure tests with shared helper

Pulling in the builder here is consistent with other Netty/Reactor tests and centralizes Dispatcher setup.

---

174-183: shutdown signature change is benign

The method only does null checks and shutdowns; removing throws Exception is appropriate.

---

185-205: Javadoc formatting only

Only spacing/blank-line adjustments in Javadoc; behavior is unaffected.

---

221-224: Expect‑header dispatcher correctly uses builder

Using the builder with a simple OK BytesRestResponse("done") preserves the original expect/continue behavior while leveraging shared defaults.

---

318-328: Bad‑request dispatcher mirrors non‑secure variant

The custom withDispatchBadRequest that records cause and sends a BAD_REQUEST response matches the non-secure Netty test and keeps the assertion that a TooLongFrameException occurred.

---

381-390: Large compressed response dispatcher preserved via builder

The lambda guarding on url and returning a large OK body is unchanged in logic; using the builder just removes anonymous class noise.

---

425-425: CORS tests still rely on pre‑dispatch handling

Using TestDispatcherBuilder.withDefaults().build() here keeps the “no application handler should be hit” invariant similar to NullDispatcher; CORS logic remains in the transport layer.

---

479-481: Read‑timeout test now uses shared dispatcher helper

Using the default builder dispatcher is consistent with other timeout tests and keeps all actual behavior in the transport.

modules/transport-netty4/src/test/java/org/opensearch/http/netty4/Netty4HttpServerTransportTests.java (7)

115-121: setup no longer declaring throws Exception is appropriate

Method body doesn’t throw checked exceptions; signature cleanup is correct.

---

123-132: shutdown cleanup is safe

Explicit shutdown and nulling of fields don’t require a checked exception; updated signature is fine.

---

173-179: Builder‑based dispatcher for expect‑header tests looks good

The dispatcher sending "done" via BytesRestResponse matches prior behavior while using the shared TestDispatcherBuilder.

---

269-280: Bad‑request dispatcher correctly focuses on dispatchBadRequest

Overriding only withDispatchBadRequest and using the builder defaults elsewhere clearly expresses the test’s intent and keeps the cause capture semantics.

---

332-341: Large compressed response dispatcher refactor is behavior‑preserving

The url guard and large OK body logic are unchanged; moving to the builder simply standardizes Dispatcher construction.

---

391-393: CORS tests leveraging default dispatcher is consistent

Using withDefaults().build() here mirrors prior NullDispatcher behavior: CORS handling occurs before any app dispatch.

---

445-447: Read‑timeout test now uses shared dispatcher helper

Default dispatcher from TestDispatcherBuilder is sufficient since the test only cares about connection closure; change is straightforward.

modules/transport-netty4/src/test/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransportTests.java (9)

31-31: Shared dispatcher helper imported for secure Netty tests

Adding TestDispatcherBuilder here brings the secure tests in line with the rest of the Netty test suite.

---

145-163: setup signature simplification is correct

Initialization does not throw checked exceptions; dropping throws Exception matches the implementation.

---

165-174: shutdown cleanup is appropriate

The teardown logic is unchanged; removing throws Exception is safe.

---

176-207: Javadoc spacing only

Only blank-line formatting in the Javadocs changed; no behavioral impact.

---

218-224: Expect‑header dispatcher correctly refactored to builder

The dispatcher’s behavior (sending "done" on success) stays the same while using the central TestDispatcherBuilder.

---

318-328: Bad‑request dispatcher logic preserved

Using withDispatchBadRequest to send a BAD_REQUEST with a custom message and track causeReference matches the previous anonymous implementation.

---

381-390: Large compressed response handler via builder is equivalent

URL check plus OK response are unchanged; builder usage simply standardizes construction across tests.

---

425-425: CORS dispatcher via withDefaults() is consistent with other tests

Relying on transport-level CORS logic with a default dispatcher keeps app-level handlers out of the path as before.

---

479-481: Read‑timeout test uses shared dispatcher pattern

Default dispatcher from the builder is sufficient here; behavior remains focused on timeout-induced close.

plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpServerTransportTests.java (9)

109-115: setup signature cleaned up correctly

No checked exceptions thrown; removing throws Exception is appropriate.

---

117-126: shutdown signature cleaned up correctly

Teardown is unchanged functionally; non-throwing signature is fine.

---

170-176: Expect‑header dispatcher via builder mirrors Netty variant

The dispatcher responding with "done" now uses TestDispatcherBuilder, matching the non-Reactor tests and keeping semantics the same.

---

257-258: Bad‑request test using default dispatcher is intentional

Using withDefaults().build() ensures any unexpected dispatch would fail the test, while URI length errors are handled at the transport layer as before.

---

301-305: Dispatch‑failed test refactor preserves 500 behavior

The custom withDispatchRequest throwing RuntimeException still drives the INTERNAL_SERVER_ERROR expectations; builder just removes boilerplate.

---

341-350: Large compressed response dispatcher refactor is behavior‑preserving

URL guard and body content checks remain identical; dispatcher is now built via the shared helper.

---

401-410: Connections‑closed test dispatcher refactor looks good

The dispatcher still serves only the expected URL and asserts on others; the looped request/response and stats checks remain unchanged.

---

446-448: CORS test using default dispatcher keeps focus on transport CORS logic

withDefaults().build() continues to ensure no app handler is needed; behavior matches other CORS tests.

---

500-502: Connect‑timeout test uses shared dispatcher helper correctly

Default dispatcher suffices; the test still validates timeout via channel closure.

plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpServerTransportStreamingTests.java (4)

63-68: Lambda simplification is fine

Changing (str) -> to str -> is a pure style tweak with no behavioral impact; XCONTENT_CONVERTER remains equivalent.

---

75-81: setup signature cleanup is appropriate

Initialization logic doesn’t throw checked exceptions; non-throwing signature is correct.

---

83-92: shutdown signature cleanup is appropriate

Teardown logic is unchanged; removing throws Exception is safe and consistent with other tests.

---

177-216: Streaming dispatcher refactor preserves behavior and clarifies responsibilities

Using TestDispatcherBuilder to:

• advertise a streaming RestHandler via withDispatchHandler (supportsStreaming=true, handleRequest guarded to fail if ever called), and
• implement the actual streaming pipeline in withDispatchRequest (asserting StreamingRestChannel, waiting for writability, emitting chunks on the WRITE executor, and closing bytesOutput if Releasable)

keeps the original streaming semantics while centralizing Dispatcher construction. The URL guard and chunking logic remain unchanged.

plugins/transport-reactor-netty4/src/test/java/org/opensearch/http/reactor/netty4/TestDispatcherBuilder.java (1)

24-86: Well-factored test dispatcher helper; defaults and delegation look correct

The builder defaults (logging + AssertionError) and the build() implementation cleanly delegate to the configured lambdas and should make dispatcher setup in tests much clearer. No issues from a correctness or test-behavior perspective.

modules/transport-netty4/src/test/java/org/opensearch/http/netty4/TestDispatcherBuilder.java (1)

24-86: Dispatcher builder implementation is correct and consistent with reactor-netty4 version

The builder’s defaults and build() delegation are sound and match the reactor-netty4 counterpart, giving consistent test behavior across modules. No functional issues spotted.